-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable build flag for openssl102 nix aarch64-linux #4045
Conversation
bf2f43f
to
cf30282
Compare
nix/openssl_1_0_2.nix
Outdated
x86_64-linux = '' | ||
./config -d ${default_options} | ||
''; | ||
aarch64-linux = '' | ||
./config ${default_options} | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the -d
for x86?
Can you add a comment about the -d
and the bug in openssl configure script as comments since thats what most of us will be reading. You could link to this PR for more info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could make it consistent and just drop all the platform filtering, but I was trying not to affect x86 with any of these changes. Adding more words...
e410a04
to
6b07252
Compare
Resolved issues:
none
Description of changes:
We're working to run integration tests on arm, but OpenSSL 1.0.2's build refuses to accept the
-d
debug flag.Working around this by removing this flag for aarch64-linux only.
Call-outs:
The error:
This appears to be a bug in the configure script of openssl102, where the $GUESSOS is expecting
aarch64-whatever-linux2
vsdebug-linux-aarch64
on line 674The openssl wiki says
-d
isn't the only way to get a debug build, and we are using-g3
:https://wiki.openssl.org/index.php/Compilation_and_Installation#Debug_Configuration
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.